From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 7 Jul 2022 21:19:12 +0000 (+0200)
Subject: path-util: NULL strings are definitely not valid paths
X-Git-Tag: v252-rc1~698^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=70980a39b84928088b24895ada6fd27c1b6680a9;p=thirdparty%2Fsystemd.git

path-util: NULL strings are definitely not valid paths

Let's make this functions that check validity of paths a bit more
friendly towards one specific kind of invalid path: a NULL pointer.

This follows similar logic in path_is_valid(), path_is_normalized() and
so on.
---

diff --git a/src/basic/path-util.h b/src/basic/path-util.h
index 553aa4fb586..3413056b310 100644
--- a/src/basic/path-util.h
+++ b/src/basic/path-util.h
@@ -43,12 +43,16 @@
 #endif
 
 static inline bool is_path(const char *p) {
-        assert(p);
+        if (!p) /* A NULL pointer is definitely not a path */
+                return false;
+
         return strchr(p, '/');
 }
 
 static inline bool path_is_absolute(const char *p) {
-        assert(p);
+        if (!p) /* A NULL pointer is definitely not an absolute path */
+                return false;
+
         return p[0] == '/';
 }