From: Nick Mathewson <nickm@torproject.org>
Date: Fri, 31 May 2019 12:26:10 +0000 (-0400)
Subject: Fix a logic error in deciding whether to accept SessionGroup=
X-Git-Tag: tor-0.4.1.3-alpha~9^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=70b85358afd0a8d4291489f9e9f5654ab2d53371;p=thirdparty%2Ftor.git

Fix a logic error in deciding whether to accept SessionGroup=

Fixes bug 22619; bugfix on 0.2.7.2-alpha
---

diff --git a/changes/bug22619 b/changes/bug22619
new file mode 100644
index 0000000000..9c71996f5b
--- /dev/null
+++ b/changes/bug22619
@@ -0,0 +1,3 @@
+  o Minor bugfixes (circuit isolation):
+    - Fix a logic error that prevented the SessionGroup sub-option from
+      being accepted. Fixes bug 22619; bugfix on 0.2.7.2-alpha.
diff --git a/src/app/config/config.c b/src/app/config/config.c
index 2a504d3065..3525597591 100644
--- a/src/app/config/config.c
+++ b/src/app/config/config.c
@@ -7080,7 +7080,7 @@ parse_port_config(smartlist_t *out,
         if (!strcasecmpstart(elt, "SessionGroup=")) {
           int group = (int)tor_parse_long(elt+strlen("SessionGroup="),
                                           10, 0, INT_MAX, &ok, NULL);
-          if (!ok || !allow_no_stream_options) {
+          if (!ok || allow_no_stream_options) {
             log_warn(LD_CONFIG, "Invalid %sPort option '%s'",
                      portname, escaped(elt));
             goto err;