From: Daniel Stone Date: Wed, 15 Oct 2025 11:00:32 +0000 (+0100) Subject: drm/rockchip: Return error code for errors X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=70e3f77cb568e229a59c5162be717bea2e22ffd8;p=thirdparty%2Fkernel%2Flinux.git drm/rockchip: Return error code for errors Instead of silently disabling small planes, refuse to create them at all. Signed-off-by: Daniel Stone Signed-off-by: Heiko Stuebner Link: https://lore.kernel.org/r/20251015110042.41273-4-daniels@collabora.com --- diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index f04fb5da12951..659b2565dee42 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1035,8 +1035,7 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, drm_dbg_kms(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is 4x4\n", drm_rect_width(src) >> 16, drm_rect_height(src) >> 16, drm_rect_width(dest), drm_rect_height(dest)); - pstate->visible = false; - return 0; + return -EINVAL; } if (drm_rect_width(src) >> 16 > vop2_data->max_input.width ||