From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 21 Jul 2020 20:13:12 +0000 (+0200)
Subject: acl-util: make sure acl_find_uid() initializes return parameters on success
X-Git-Tag: v247-rc1~362^2~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=71281a7655d637bed06071e61c28a96fbf7370bb;p=thirdparty%2Fsystemd.git

acl-util: make sure acl_find_uid() initializes return parameters on success

Let's follow our usual coding style and initialize return parameters on
success in all cases.
---

diff --git a/src/shared/acl-util.c b/src/shared/acl-util.c
index dd2b1efb112..641e5bda7a1 100644
--- a/src/shared/acl-util.c
+++ b/src/shared/acl-util.c
@@ -12,12 +12,13 @@
 #include "user-util.h"
 #include "util.h"
 
-int acl_find_uid(acl_t acl, uid_t uid, acl_entry_t *entry) {
+int acl_find_uid(acl_t acl, uid_t uid, acl_entry_t *ret_entry) {
         acl_entry_t i;
         int r;
 
         assert(acl);
-        assert(entry);
+        assert(uid_is_valid(uid));
+        assert(ret_entry);
 
         for (r = acl_get_entry(acl, ACL_FIRST_ENTRY, &i);
              r > 0;
@@ -41,13 +42,14 @@ int acl_find_uid(acl_t acl, uid_t uid, acl_entry_t *entry) {
                 acl_free(u);
 
                 if (b) {
-                        *entry = i;
+                        *ret_entry = i;
                         return 1;
                 }
         }
         if (r < 0)
                 return -errno;
 
+        *ret_entry = NULL;
         return 0;
 }