From: Ralph Boehme Date: Tue, 16 Feb 2021 13:24:05 +0000 (+0100) Subject: printing: use correct error out in get_correct_cversion() when openat_pathref_fsp... X-Git-Tag: tevent-0.11.0~1739 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=718f7b1a84f1c6eb35d52232a8573370f45add56;p=thirdparty%2Fsamba.git printing: use correct error out in get_correct_cversion() when openat_pathref_fsp() fails Fixes a regression introduced by a74f0af1a91fe0bbc68e4d41d65f43ec383ae8bf: if there's no existing file, openat_pathref_fsp() will fail with NT_STATUS_OBJECT_NAME_NOT_FOUND which must be handled the same way it is done by the SMB_VFS_CREATE_FILE() call below. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14635 Signed-off-by: Ralph Boehme Reviewed-by: Guenther Deschner Autobuild-User(master): Günther Deschner Autobuild-Date(master): Wed Feb 17 19:53:00 UTC 2021 on sn-devel-184 --- diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c index e3cd8102851..e9253093ae2 100644 --- a/source3/printing/nt_printing.c +++ b/source3/printing/nt_printing.c @@ -1104,7 +1104,10 @@ static uint32_t get_correct_cversion(const struct auth_session_info *session_inf nt_status = openat_pathref_fsp(conn->cwd_fsp, smb_fname); if (!NT_STATUS_IS_OK(nt_status)) { - return false; + DBG_NOTICE("Can't open file [%s], errno =%d\n", + smb_fname_str_dbg(smb_fname), errno); + *perr = WERR_ACCESS_DENIED; + goto error_exit; } nt_status = SMB_VFS_CREATE_FILE(