From: Noel Power <noel.power@suse.com>
Date: Mon, 8 Jul 2019 15:16:57 +0000 (+0000)
Subject: libcli/smb: clang: Fix 'value stored to 'p' is never read'
X-Git-Tag: talloc-2.3.0~114
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=71943ab53ee67dab0bb47753b78074917f38749e;p=thirdparty%2Fsamba.git

libcli/smb: clang: Fix 'value stored to 'p' is never read'

Fixes:

libcli/smb/smb1cli_session.c:226:2: warning: Value stored to 'p' is never read <--[clang]
        p += ret;
        ^    ~~~
libcli/smb/smb1cli_session.c:517:2: warning: Value stored to 'p' is never read <--[clang]
        p += ret;
        ^    ~~~
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/libcli/smb/smb1cli_session.c b/libcli/smb/smb1cli_session.c
index 11614df0ae4..a8ad9b87695 100644
--- a/libcli/smb/smb1cli_session.c
+++ b/libcli/smb/smb1cli_session.c
@@ -223,7 +223,6 @@ static void smb1cli_session_setup_lm21_done(struct tevent_req *subreq)
 	if (tevent_req_nterror(req, status)) {
 		return;
 	}
-	p += ret;
 
 	smb1cli_session_set_id(state->session, state->out_session_id);
 	smb1cli_session_set_action(state->session, state->out_action);
@@ -514,7 +513,6 @@ static void smb1cli_session_setup_nt1_done(struct tevent_req *subreq)
 	if (tevent_req_nterror(req, status)) {
 		return;
 	}
-	p += ret;
 
 	smb1cli_session_set_id(state->session, state->out_session_id);
 	smb1cli_session_set_action(state->session, state->out_action);