From: Timo Sirainen <tss@iki.fi>
Date: Thu, 5 Mar 2009 23:24:19 +0000 (-0500)
Subject: dbox: Saving shouldn't close any files after all, otherwise locks are lost.
X-Git-Tag: 2.0.alpha1~1038^2~66
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=71b9a08716adec8b5c2c094cea7bdaff5e18bc1f;p=thirdparty%2Fdovecot%2Fcore.git

dbox: Saving shouldn't close any files after all, otherwise locks are lost.

--HG--
branch : HEAD
---

diff --git a/src/lib-storage/index/dbox/dbox-map.c b/src/lib-storage/index/dbox/dbox-map.c
index d06d846dff..f2fbec9eea 100644
--- a/src/lib-storage/index/dbox/dbox-map.c
+++ b/src/lib-storage/index/dbox/dbox-map.c
@@ -481,6 +481,7 @@ dbox_map_find_appendable_file(struct dbox_map_append_context *ctx,
 			return 1;
 		}
 		/* can't append to this file anymore */
+#if 0 /* FIXME: we can't close files, otherwise we lose the lock too early */
 		if (files[i-1]->fd != -1) {
 			/* avoid wasting fds by closing the file, but not if
 			   we're also reading from it. */
@@ -490,6 +491,7 @@ dbox_map_find_appendable_file(struct dbox_map_append_context *ctx,
 			if (files[i-1]->refcount == 1)
 				dbox_file_close(files[i-1]);
 		}
+#endif
 	}
 	ctx->files_nonappendable_count = count;