From: Sam James Date: Wed, 19 Oct 2022 22:58:39 +0000 (+0100) Subject: pem: fix -Wunused-but-set-variable X-Git-Tag: openssl-3.2.0-alpha1~1859 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=71bc497dc321adeb08e7541556dea019c81c9a87;p=thirdparty%2Fopenssl.git pem: fix -Wunused-but-set-variable The loop never uses the value of 'line'. Fixes this error with Clang 15: ``` crypto/pem/pem_lib.c:821:14: error: variable 'line' set but not used [-Werror,-Wunused-but-set-variable] int len, line, ret = 0, end = 0, prev_partial_line_read = 0, partial_line_read = 0; ^ 1 error generated. ``` Signed-off-by: Sam James Reviewed-by: Paul Dale Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19450) --- diff --git a/crypto/pem/pem_lib.c b/crypto/pem/pem_lib.c index 4c6b94da6b0..4035ac64e67 100644 --- a/crypto/pem/pem_lib.c +++ b/crypto/pem/pem_lib.c @@ -818,7 +818,7 @@ static int get_header_and_data(BIO *bp, BIO **header, BIO **data, char *name, { BIO *tmp = *header; char *linebuf, *p; - int len, line, ret = 0, end = 0, prev_partial_line_read = 0, partial_line_read = 0; + int len, ret = 0, end = 0, prev_partial_line_read = 0, partial_line_read = 0; /* 0 if not seen (yet), 1 if reading header, 2 if finished header */ enum header_status got_header = MAYBE_HEADER; unsigned int flags_mask; @@ -830,7 +830,7 @@ static int get_header_and_data(BIO *bp, BIO **header, BIO **data, char *name, if (linebuf == NULL) return 0; - for (line = 0; ; line++) { + while(1) { flags_mask = ~0u; len = BIO_gets(bp, linebuf, LINESIZE); if (len <= 0) {