From: Barry Warsaw Date: Sat, 20 Jan 2001 06:08:10 +0000 (+0000) Subject: default_3way_compare(): When comparing the pointers, they must be cast X-Git-Tag: v2.1a1~87 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=71ff8d5dc5dad320cf71fee03018c5ba4101b683;p=thirdparty%2FPython%2Fcpython.git default_3way_compare(): When comparing the pointers, they must be cast to integer types (i.e. Py_uintptr_t, our spelling of C9X's uintptr_t). ANSI specifies that pointer compares other than == and != to non-related structures are undefined. This quiets an Insure portability warning. --- diff --git a/Objects/object.c b/Objects/object.c index 44344f9b2c25..e2a019fdf7ce 100644 --- a/Objects/object.c +++ b/Objects/object.c @@ -525,8 +525,8 @@ default_3way_compare(PyObject *v, PyObject *w) if (v->ob_type == w->ob_type) { /* same type: compare pointers */ - void *vv = v; - void *ww = w; + Py_uintptr_t vv = (Py_uintptr_t)v; + Py_uintptr_t ww = (Py_uintptr_t)w; return (vv < ww) ? -1 : (vv > ww) ? 1 : 0; }