From: Volker Lendecke Date: Mon, 26 Feb 2018 12:14:21 +0000 (+0100) Subject: winbind: "internal" children never have a domain set X-Git-Tag: talloc-2.1.12~342 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=723560aed2082fefdb0f9d27548fda200438bc8a;p=thirdparty%2Fsamba.git winbind: "internal" children never have a domain set Look at setup_domain_child(): There we always set child->domain. The only other two children are the idmap and locator children, which don't have a domain set. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309 Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider --- diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c index 3c949d943f9..a7d1ceedcb5 100644 --- a/source3/winbindd/winbindd_dual.c +++ b/source3/winbindd/winbindd_dual.c @@ -897,9 +897,8 @@ void winbind_msg_offline(struct messaging_context *msg_ctx, } for (child = winbindd_children; child != NULL; child = child->next) { - /* Don't send message to internal children. We've already - done so above. */ - if (!child->domain || winbindd_internal_child(child)) { + /* Only set domain children offline */ + if (child->domain == NULL) { continue; } @@ -972,8 +971,8 @@ void winbind_msg_online(struct messaging_context *msg_ctx, } for (child = winbindd_children; child != NULL; child = child->next) { - /* Don't send message to internal childs. */ - if (!child->domain || winbindd_internal_child(child)) { + /* Only set domain children online */ + if (child->domain == NULL) { continue; }