From: JINMEI Tatuya <jinmei@isc.org>
Date: Mon, 28 Jan 2013 00:06:45 +0000 (+0530)
Subject: [2435] Check result of find() in test
X-Git-Tag: bind10-1.0.0-rc-release~82
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=72383e89593fdc91a83b0ffe875a4fdb5114fbfc;p=thirdparty%2Fkea.git

[2435] Check result of find() in test
---

diff --git a/src/lib/datasrc/tests/database_unittest.cc b/src/lib/datasrc/tests/database_unittest.cc
index 6b12b3a118..a0fc6bf313 100644
--- a/src/lib/datasrc/tests/database_unittest.cc
+++ b/src/lib/datasrc/tests/database_unittest.cc
@@ -4390,11 +4390,13 @@ TYPED_TEST(RRsetCollectionAndUpdaterTest, updateThrows) {
     this->updater_.reset();
     this->updater_ = this->client_->getUpdater(this->zname_, false);
 
-    // Just call getRRsetCollection() here. The .find() is unnecessary,
-    // but we have it to use the result of getRRsetCollection().
-    this->updater_->getRRsetCollection().find(Name("www.example.org"),
-                                              RRClass::IN(),
-                                              RRType::MX());
+    // Just call getRRsetCollection() here. The test using .find() is
+    // unnecessary for the purpose of this test case, but we have it to
+    // use the result of getRRsetCollection() and silence some compiler
+    // complaining about ignoring the return value of
+    // getRRsetCollection().
+    EXPECT_FALSE(this->updater_->getRRsetCollection().
+                 find(Name("www.example.org"), RRClass::IN(), RRType::MX()));
 
     // addRRset() must throw isc::InvalidOperation here.
     EXPECT_THROW(this->updater_->addRRset(*this->rrset_),