From: Shixin Liu <liushixin2@huawei.com>
Date: Thu, 8 Apr 2021 07:18:37 +0000 (+0800)
Subject: crypto: sa2ul - Fix PM reference leak in sa_ul_probe()
X-Git-Tag: v5.12.3~254
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=728936b641fcb43b494b63f22b0fbac94229c5f3;p=thirdparty%2Fkernel%2Fstable.git

crypto: sa2ul - Fix PM reference leak in sa_ul_probe()

[ Upstream commit 13343badae093977295341d5a050f51ef128821c ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index f300b0a5958a5..d7b1628fb4848 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -2350,7 +2350,7 @@ static int sa_ul_probe(struct platform_device *pdev)
 	dev_set_drvdata(sa_k3_dev, dev_data);
 
 	pm_runtime_enable(dev);
-	ret = pm_runtime_get_sync(dev);
+	ret = pm_runtime_resume_and_get(dev);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__,
 			ret);