From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 17 Feb 2021 15:41:51 +0000 (+0000)
Subject: Fix sign comparison
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=72fd3fbc45a2600a89be9a8eb9b7c472d6f27ea5;p=thirdparty%2Ffreeradius-server.git

Fix sign comparison
---

diff --git a/src/modules/rlm_expiration/rlm_expiration.c b/src/modules/rlm_expiration/rlm_expiration.c
index f4ad919bb63..47d7fbbad3c 100644
--- a/src/modules/rlm_expiration/rlm_expiration.c
+++ b/src/modules/rlm_expiration/rlm_expiration.c
@@ -112,11 +112,11 @@ static unlang_action_t CC_HINT(nonnull) mod_authorize(rlm_rcode_t *p_result, UNU
  */
 static int expirecmp(UNUSED void *instance, request_t *req, UNUSED fr_pair_list_t *request_list, fr_pair_t *check)
 {
-	time_t now = 0;
+	fr_unix_time_t now = 0;
 
-	now = (req) ? fr_time_to_sec(req->packet->timestamp) : time(NULL);
+	now = (fr_unix_time_t)((req) ? fr_time_to_sec(req->packet->timestamp) : time(NULL));
 
-	if (now <= (time_t) fr_unix_time_to_sec(check->vp_date)) return 0;
+	if (now <= fr_unix_time_to_sec(check->vp_date)) return 0;
 
 	return 1;
 }