From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Mon, 23 Dec 2024 00:07:40 +0000 (+1300)
Subject: ldb: fix Coverity 1636883
X-Git-Tag: tdb-1.4.13~248
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=73107aa9f6ac455acdef629e3e41e6dcd34fb929;p=thirdparty%2Fsamba.git

ldb: fix Coverity 1636883

oops.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Dec 30 04:17:46 UTC 2024 on atb-devel-224
---

diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c
index 0af0d94826a..5b8c0f4f580 100644
--- a/lib/ldb/common/ldb_dn.c
+++ b/lib/ldb/common/ldb_dn.c
@@ -969,7 +969,7 @@ static bool ldb_dn_casefold_internal(struct ldb_dn *dn)
 	 */
 	TALLOC_FREE(dn->components[i].cf_name);
   failed:
-	for (j = 0; j < i; i++) {
+	for (j = 0; j < i; j++) {
 		TALLOC_FREE(dn->components[j].cf_name);
 		TALLOC_FREE(dn->components[j].cf_value.data);
 	}