From: Markus Metzger Date: Mon, 24 Jun 2024 08:21:17 +0000 (+0000) Subject: gdb, remote: adjust debug printing X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=732ed016e23e77b9351d3c363cc13fc3082027e8;p=thirdparty%2Fbinutils-gdb.git gdb, remote: adjust debug printing remote::wait () may get called rather frequently, polluting the logging output with tons of [remote] wait: enter [remote] wait: exit messages. Similarly, remote_target::remote_notif_remove_queued_reply () will print the debug message even if nothing was actually removed. Change that to only print a debug message if a stop reply was removed. Approved-By: Tom Tromey --- diff --git a/gdb/remote.c b/gdb/remote.c index 858076bfa42..88dc7c09184 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -8275,12 +8275,12 @@ remote_target::remote_notif_remove_queued_reply (ptid_t ptid) { result = std::move (*iter); rs->stop_reply_queue.erase (iter); - } - if (notif_debug) - gdb_printf (gdb_stdlog, - "notif: discard queued event: 'Stop' in %s\n", - ptid.to_string ().c_str ()); + if (notif_debug) + gdb_printf (gdb_stdlog, + "notif: discard queued event: 'Stop' in %s\n", + ptid.to_string ().c_str ()); + } return result; } @@ -9186,8 +9186,6 @@ ptid_t remote_target::wait (ptid_t ptid, struct target_waitstatus *status, target_wait_flags options) { - REMOTE_SCOPED_DEBUG_ENTER_EXIT; - remote_state *rs = get_remote_state (); /* Start by clearing the flag that asks for our wait method to be called,