From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 13 May 2019 15:39:50 +0000 (-0700)
Subject: bpo-36903: Fix ResourceWarning in test_logging (GH-13283) (GH-13285)
X-Git-Tag: v3.7.4rc1~162
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=744129db5d4e7706fd7d46dfc691aa47fabd66fa;p=thirdparty%2FPython%2Fcpython.git

bpo-36903: Fix ResourceWarning in test_logging (GH-13283) (GH-13285)

(cherry picked from commit 2c10538d11fa9be9a1a9f21605861e10ec4fa207)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
---

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 42746d40d2cd..14277369be47 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -689,6 +689,7 @@ class HandlerTest(BaseTest):
 
         self.assertEqual(len(logging._handlers), 0)
         refed_h = _OurHandler()
+        self.addCleanup(refed_h.sub_handler.stream.close)
         refed_h.name = 'because we need at least one for this test'
         self.assertGreater(len(logging._handlers), 0)
         self.assertGreater(len(logging._at_fork_reinit_lock_weakset), 1)