From: Mukund Sivaraman Date: Thu, 14 Jun 2012 07:58:20 +0000 (+0530) Subject: [1828] Cleanup code by using with (for accept_sock) X-Git-Tag: trac2351_base~226^2~42^2~1^2~8 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=74b4b2f998f9512b2a326e81062da9099d1eeaf4;p=thirdparty%2Fkea.git [1828] Cleanup code by using with (for accept_sock) --- diff --git a/src/lib/python/isc/util/cio/tests/socketsession_test.py b/src/lib/python/isc/util/cio/tests/socketsession_test.py index 47c67e5606..eba9fa2413 100644 --- a/src/lib/python/isc/util/cio/tests/socketsession_test.py +++ b/src/lib/python/isc/util/cio/tests/socketsession_test.py @@ -237,11 +237,10 @@ class TestForwarder(unittest.TestCase): s = socket.socket(socket.AF_UNIX, SOCK_STREAM, 0) s.setblocking(False) s.connect(TEST_UNIX_FILE) - accept_sock = self.accept_forwarder() - receiver = SocketSessionReceiver(accept_sock) - s.close() - self.assertRaises(SocketSessionError, receiver.pop) - accept_sock.close() + with self.accept_forwarder() as accept_sock: + receiver = SocketSessionReceiver(accept_sock) + s.close() + self.assertRaises(SocketSessionError, receiver.pop) class TestReceiver(unittest.TestCase): # We only check a couple of failure cases on construction. Valid cases