From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 2 May 2019 22:10:01 +0000 (+1200)
Subject: rpc/dnsdata: avoid crash on missing attr (CID: 1414757)
X-Git-Tag: tdb-1.4.1~142
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=74cd11df838815dbef2a505e58c2cb863a82be97;p=thirdparty%2Fsamba.git

rpc/dnsdata: avoid crash on missing attr (CID: 1414757)

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c
index 6a211ad9efd..415a7c57a0f 100644
--- a/source4/rpc_server/dnsserver/dnsdata.c
+++ b/source4/rpc_server/dnsserver/dnsdata.c
@@ -968,6 +968,12 @@ WERROR dns_fill_records_array(TALLOC_CTX *mem_ctx,
 	}
 
 	ptr = ldb_msg_find_attr_as_string(msg, "name", NULL);
+	if (ptr == NULL) {
+		DBG_ERR("dnsserver: dns record has no name (%s)",
+			ldb_dn_get_linearized(msg->dn));
+		return WERR_INTERNAL_DB_ERROR;
+	}
+
 	el = ldb_msg_find_element(msg, "dnsRecord");
 	if (el == NULL || el->values == 0) {
 		return WERR_OK;