From: Maciej S. Szmigiero Date: Thu, 20 Oct 2022 20:46:23 +0000 (+0200) Subject: ALSA: hda/realtek: Use snd_ctl_rename() to rename a control X-Git-Tag: v6.0.7~230 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=74e988ee3e7ec22d0b30d180d8e6731c6647a97f;p=thirdparty%2Fkernel%2Fstable.git ALSA: hda/realtek: Use snd_ctl_rename() to rename a control commit b51c225376a684d02fb58b49cf0ce3d693b6f14b upstream. With the recent addition of hashed controls lookup it's not enough to just update the control name field, the hash entries for the modified control have to be updated too. snd_ctl_rename() takes care of that, so use it instead of directly modifying the control name. Fixes: c27e1efb61c5 ("ALSA: control: Use xarray for faster lookups") Cc: stable@vger.kernel.org Signed-off-by: Maciej S. Szmigiero Link: https://lore.kernel.org/r/37496bd80f91f373268148f877fd735917d97287.1666296963.git.maciej.szmigiero@oracle.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 210d662ce6a92..6e25a0f89f6b4 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2141,7 +2141,7 @@ static void rename_ctl(struct hda_codec *codec, const char *oldname, kctl = snd_hda_find_mixer_ctl(codec, oldname); if (kctl) - strcpy(kctl->id.name, newname); + snd_ctl_rename(codec->card, kctl, newname); } static void alc1220_fixup_gb_dual_codecs(struct hda_codec *codec,