From: Doug MacEachern <dougm@apache.org>
Date: Thu, 28 Feb 2002 19:11:31 +0000 (+0000)
Subject: plug leak in newish ssl_asn1_table_set() function
X-Git-Tag: 2.0.33~75
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=750c48848b32e41a8a09cab101319a9ac2125502;p=thirdparty%2Fapache%2Fhttpd.git

plug leak in newish ssl_asn1_table_set() function


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@93648 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/ssl/ssl_engine_ds.c b/modules/ssl/ssl_engine_ds.c
index 39696fa285a..38dbc6799dc 100644
--- a/modules/ssl/ssl_engine_ds.c
+++ b/modules/ssl/ssl_engine_ds.c
@@ -212,9 +212,11 @@ unsigned char *ssl_asn1_table_set(apr_hash_t *table,
      * reuse as much of the already malloc-ed data
      * as possible.
      */
-    if (asn1 && (asn1->nData != length)) {
-        free(asn1->cpData); /* XXX: realloc? */
-        asn1->cpData = NULL;
+    if (asn1) {
+        if (asn1->nData != length) {
+            free(asn1->cpData); /* XXX: realloc? */
+            asn1->cpData = NULL;
+        }
     }
     else {
         asn1 = malloc(sizeof(*asn1));