From: Ralph Boehme <slow@samba.org>
Date: Tue, 27 Oct 2020 20:13:12 +0000 (+0100)
Subject: smbd: always use check_access_fsp() in smb_set_file_basic_info()
X-Git-Tag: samba-4.14.0rc1~304
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=752bc3881cfe31b85e38c04564e384a90a354b94;p=thirdparty%2Fsamba.git

smbd: always use check_access_fsp() in smb_set_file_basic_info()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 5ab3c285ca7..a2196b70995 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -7838,15 +7838,7 @@ static NTSTATUS smb_set_file_basic_info(connection_struct *conn,
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 
-	if (fsp != NULL) {
-		status = check_access_fsp(fsp, FILE_WRITE_ATTRIBUTES);
-	} else {
-		status = smbd_check_access_rights(conn,
-				conn->cwd_fsp,
-				smb_fname,
-				false,
-				FILE_WRITE_ATTRIBUTES);
-	}
+	status = check_access_fsp(fsp, FILE_WRITE_ATTRIBUTES);
 	if (!NT_STATUS_IS_OK(status)) {
 		return status;
 	}