From: Jeremy Allison <jra@samba.org>
Date: Tue, 21 Nov 2017 00:09:39 +0000 (+0000)
Subject: s3: utils: net. Fix return paths that don't free talloc stackframe.
X-Git-Tag: talloc-2.1.11~436
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=757a120fc4c659047bd6a1175b24f0673630ce2d;p=thirdparty%2Fsamba.git

s3: utils: net. Fix return paths that don't free talloc stackframe.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13151

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
---

diff --git a/source3/utils/net_usershare.c b/source3/utils/net_usershare.c
index 78d38daaf97..8357296f727 100644
--- a/source3/utils/net_usershare.c
+++ b/source3/utils/net_usershare.c
@@ -647,13 +647,16 @@ static int net_usershare_add(struct net_context *c, int argc, const char **argv)
 	us_comment = "";
 	arg_acl = "S-1-1-0:R";
 
-	if (c->display_usage)
+	if (c->display_usage) {
+		TALLOC_FREE(ctx);
 		return net_usershare_add_usage(c, argc, argv);
+	}
 
 	switch (argc) {
 		case 0:
 		case 1:
 		default:
+			TALLOC_FREE(ctx);
 			return net_usershare_add_usage(c, argc, argv);
 		case 2:
 			cp_sharename = argv[0];