From: Guido van Rossum <guido@python.org>
Date: Tue, 24 Dec 2002 18:10:07 +0000 (+0000)
Subject: Add an XXX comment about relative imports.
X-Git-Tag: v2.3c1~2884
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=75bfd0585b9f197845fd7a429715807175c33e9f;p=thirdparty%2FPython%2Fcpython.git

Add an XXX comment about relative imports.
---

diff --git a/Modules/cPickle.c b/Modules/cPickle.c
index b83e76581a62..9412ad9718ca 100644
--- a/Modules/cPickle.c
+++ b/Modules/cPickle.c
@@ -1713,9 +1713,10 @@ save_global(Picklerobject *self, PyObject *args, PyObject *name)
 	module_str = PyString_AS_STRING((PyStringObject *)module);
 	name_str   = PyString_AS_STRING((PyStringObject *)global_name);
 
+	/* XXX This can be doing a relative import.  Clearly it shouldn't,
+	   but I don't know how to stop it. :-( */
 	mod = PyImport_ImportModule(module_str);
 	if (mod == NULL) {
-		/* Py_ErrClear(); ?? */
 		cPickle_ErrFormat(PicklingError,
 				  "Can't pickle %s: it's not found as %s.%s",
 				  "OSS", args, module, global_name);