From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 20 Oct 2025 12:34:28 +0000 (+0200)
Subject: Merge pull request #16190 from omoerbeek/rec-more-ottracing
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=75dca4d8e9408011d68756221cf5e8dd5cd0a650;p=thirdparty%2Fpdns.git

Merge pull request #16190 from omoerbeek/rec-more-ottracing

rec: OT tracing: define more Spans with actual duration and add more attributes
---

75dca4d8e9408011d68756221cf5e8dd5cd0a650
diff --cc pdns/recursordist/rec-main.cc
index 365a1d13f3,8c01a5eca7..c1d0f6101c
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@@ -636,12 -633,12 +636,15 @@@ void protobufLogResponse(const DNSName
      pbMessage.addEvents(eventTrace);
    }
    if (eventTrace.enabled() && (SyncRes::s_event_trace_enabled & SyncRes::event_trace_to_ot) != 0) {
-     auto trace = pdns::trace::TracesData::boilerPlate("rec", qname.toLogString() + '/' + qtype.toString(), eventTrace.convertToOT(otTrace));
+     auto trace = pdns::trace::TracesData::boilerPlate("rec", eventTrace.convertToOT(otTrace),
+                                                       {{"query.qname", {qname.toLogString()}},
+                                                        {"query.qtype", {qtype.toString()}}},
+                                                       SyncRes::s_serverID);
      pbMessage.setOpenTelemetryData(trace.encode());
    }
 +  if (otTrace.trace_id != pdns::trace::s_emptyTraceID) {
 +    pbMessage.setOpenTelemetryTraceID(otTrace.trace_id);
 +  }
    pbMessage.addPolicyTags(policyTags);
  
    protobufLogResponse(pbMessage);