From: Jeremy Allison <jra@samba.org>
Date: Fri, 4 Jun 2021 20:27:52 +0000 (-0700)
Subject: s3: smbd: Remove is_visible_file() from dptr_ReadDirName().
X-Git-Tag: tevent-0.11.0~564
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=75f7c11bb35c3977ec7e9fd937bd6fd40f5013bf;p=thirdparty%2Fsamba.git

s3: smbd: Remove is_visible_file() from dptr_ReadDirName().

dptr_ReadDirName() is only called from smbd_dirptr_get_entry(),
which is now doing it's own call to is_visible_fsp().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/dir.c b/source3/smbd/dir.c
index 287e7cbba10..6dfb9d93d90 100644
--- a/source3/smbd/dir.c
+++ b/source3/smbd/dir.c
@@ -473,19 +473,6 @@ static char *dptr_ReadDirName(TALLOC_CTX *ctx,
 
 	dptr->did_stat = true;
 
-	/* First check if it should be visible. */
-	if (!is_visible_file(dptr->conn,
-			dptr->dir_hnd,
-			dptr->wcard,
-			pst,
-			true)) {
-		/* This only returns false if the file was found, but
-		   is explicitly not visible. Set us to end of
-		   directory, but return NULL as we know we can't ever
-		   find it. */
-		goto ret;
-	}
-
 	if (VALID_STAT(*pst)) {
 		name = talloc_strdup(ctx, dptr->wcard);
 		goto ret;