From: Volker Lendecke <vl@samba.org>
Date: Sat, 1 Apr 2023 09:57:47 +0000 (+0200)
Subject: libsmb: Make setting errno safer in SMBC_add_cached_server()
X-Git-Tag: talloc-2.4.1~894
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76497f705f7737c8d54ea23554e6b10e400ed4df;p=thirdparty%2Fsamba.git

libsmb: Make setting errno safer in SMBC_add_cached_server()

DEBUG should preserve errno, but make this more obvious.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/libsmb/libsmb_cache.c b/source3/libsmb/libsmb_cache.c
index b1a2d3d60cf..91292b1b3e2 100644
--- a/source3/libsmb/libsmb_cache.c
+++ b/source3/libsmb/libsmb_cache.c
@@ -57,8 +57,8 @@ SMBC_add_cached_server(SMBCCTX * context,
 
 	srvcache = SMB_CALLOC_ARRAY(struct smbc_server_cache, 1);
 	if (srvcache == NULL) {
-		errno = ENOMEM;
 		DEBUG(3, ("Not enough space for server cache allocation\n"));
+		errno = ENOMEM;
 		return 1;
 	}