From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 30 Nov 2023 03:20:02 +0000 (+1300)
Subject: lib:crypto: Remove redundant array zeroing
X-Git-Tag: talloc-2.4.2~417
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7658c9bf0a9c99e3f200571;p=thirdparty%2Fsamba.git

lib:crypto: Remove redundant array zeroing

The call to memset_s() was supposed to replace the use of
ZERO_ARRAY_LEN(), but somehow both lines have crept in.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/crypto/gnutls_sp800_108.c b/lib/crypto/gnutls_sp800_108.c
index 65710657bae..fb0aa039213 100644
--- a/lib/crypto/gnutls_sp800_108.c
+++ b/lib/crypto/gnutls_sp800_108.c
@@ -224,7 +224,6 @@ out:
 	if (!NT_STATUS_IS_OK(status)) {
 		/* Hide the evidence. */
 		memset_s(KO, KO_len, 0, KO_idx);
-		ZERO_ARRAY_LEN(KO, KO_idx);
 	}
 
 	return status;