From: Noel Power Date: Fri, 5 Jul 2019 10:24:53 +0000 (+0000) Subject: s4/auth/kerberos: clang: Fix 'value stored to 'ret' is never read ' X-Git-Tag: tdb-1.4.2~511 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=765fc314e4aee455bae0f391a7d388584b48bb4a;p=thirdparty%2Fsamba.git s4/auth/kerberos: clang: Fix 'value stored to 'ret' is never read ' Fixes: source4/auth/kerberos/kerberos_pac.c:116:2: warning: Value stored to 'ret' is never read <--[clang] ret = smb_krb5_make_pac_checksum(mem_ctx, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- diff --git a/source4/auth/kerberos/kerberos_pac.c b/source4/auth/kerberos/kerberos_pac.c index e45a846cd88..54ef4d61b02 100644 --- a/source4/auth/kerberos/kerberos_pac.c +++ b/source4/auth/kerberos/kerberos_pac.c @@ -120,6 +120,13 @@ &srv_checksum->type, &srv_checksum->signature); + if (ret) { + DBG_WARNING("making krbtgt PAC srv_checksum failed: %s\n", + smb_get_krb5_error_message(context, ret, mem_ctx)); + talloc_free(pac_data); + return ret; + } + /* Then sign Server checksum */ ret = smb_krb5_make_pac_checksum(mem_ctx, &srv_checksum->signature, @@ -128,8 +135,8 @@ &kdc_checksum->type, &kdc_checksum->signature); if (ret) { - DEBUG(2, ("making krbtgt PAC checksum failed: %s\n", - smb_get_krb5_error_message(context, ret, mem_ctx))); + DBG_WARNING("making krbtgt PAC kdc_checksum failed: %s\n", + smb_get_krb5_error_message(context, ret, mem_ctx)); talloc_free(pac_data); return ret; }