From: Volker Lendecke <vl@samba.org>
Date: Thu, 3 Dec 2020 16:03:32 +0000 (+0100)
Subject: smbd: Remove a comment that was not helpful for me
X-Git-Tag: samba-4.14.0rc1~503
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7677c40fa5587e0ac29427639011ae4e7c562d04;p=thirdparty%2Fsamba.git

smbd: Remove a comment that was not helpful for me

Also avoid an "else" branch

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c
index 2592c9efa4c..98fa9f019a5 100644
--- a/source3/locking/share_mode_lock.c
+++ b/source3/locking/share_mode_lock.c
@@ -988,17 +988,9 @@ static int share_mode_lock_destructor(struct share_mode_lock *lck)
 		 */
 		share_mode_memcache_store(static_share_mode_data);
 		static_share_mode_data = NULL;
-	} else {
-		/*
-		 * The next opener of this file will find an empty
-		 * locking.tdb record. Don't store the share_mode_data
-		 * in the memcache, fresh_share_mode_lock() will
-		 * generate a fresh seqnum anyway, obsoleting the
-		 * cache entry.
-		 */
-		TALLOC_FREE(static_share_mode_data);
 	}
 
+	TALLOC_FREE(static_share_mode_data);
 	return 0;
 }