From: Sebastian Hahn <sebastian@torproject.org>
Date: Tue, 23 Feb 2010 14:02:34 +0000 (+0100)
Subject: Fix another coverity-spotted memleak
X-Git-Tag: tor-0.2.2.10-alpha~24
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7681e355ed5da8d4f41bfc5a3fc0b1bcf67add45;p=thirdparty%2Ftor.git

Fix another coverity-spotted memleak
---

diff --git a/ChangeLog b/ChangeLog
index dc4cfe86c6..ef866292f9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Changes in version 0.2.2.10-alpha - 2010-??-??
+  o Minor bugfixes:
+    - Fix a memleak in the EXTENDCIRCUIT logic. Spotted by coverity.
+      Bugfix on 0.2.2.9-alpha.
+
 Changes in version 0.2.2.9-alpha - 2010-02-22
   o Directory authority changes:
     - Change IP address for dannenberg (v3 directory authority), and
diff --git a/src/or/control.c b/src/or/control.c
index 0f71855286..5101fdef42 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -2121,6 +2121,8 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len,
   if (!zero_circ && !(circ = get_circ(smartlist_get(args,0)))) {
     connection_printf_to_buf(conn, "552 Unknown circuit \"%s\"\r\n",
                              (char*)smartlist_get(args, 0));
+    SMARTLIST_FOREACH(args, char *, cp, tor_free(cp));
+    smartlist_free(args);
     goto done;
   }