From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 10 Jan 2018 17:14:36 +0000 (-0500)
Subject: note todo for overlapping networks
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=768aba3c8ac3cbf2b2b08562e3257f0b4c48d746;p=thirdparty%2Ffreeradius-server.git

note todo for overlapping networks

e.g.

192.168/16 is allowed, and so is 192.168.1/24.  They're overlapping
and the second is unnecessary.
---

diff --git a/src/modules/proto_radius/proto_radius_udp.c b/src/modules/proto_radius/proto_radius_udp.c
index baa77644e91..c557ee81e8e 100644
--- a/src/modules/proto_radius/proto_radius_udp.c
+++ b/src/modules/proto_radius/proto_radius_udp.c
@@ -1406,6 +1406,15 @@ static int mod_bootstrap(void *instance, CONF_SECTION *cs)
 				return -1;
 			}
 
+			/*
+			 *	@todo - look for 192.168/16 followed
+			 *	by 192.168.1/24, or vice-versa.
+			 *	i.e. the networks MUST be disjoint!
+			 *
+			 *	Or maybe that can be added as a flag
+			 *	to fr_trie_alloc() ?
+			 */
+
 			/*
 			 *	Insert the network into the trie.
 			 *	Lookups will return the fr_ipaddr_t of