From: Georgia Garcia <georgia.garcia@canonical.com>
Date: Tue, 7 Jan 2025 15:23:36 +0000 (-0300)
Subject: security_apparmor: fix memleaks in AppArmorSetFDLabel
X-Git-Tag: v11.0.0-rc1~26
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76b9227eea22df53e4772c9e048074ea90b903a9;p=thirdparty%2Flibvirt.git

security_apparmor: fix memleaks in AppArmorSetFDLabel

proc and fd_path are allocated but never freed. Fix by using
g_autofree instead.

Fixes: b9757fea30785a92aa95ea675b9bc371e4fb2e8c
Signed-off-by: Georgia Garcia <georgia.garcia@canonical.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
---

diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c
index eed0f265d6..ae2175d334 100644
--- a/src/security/security_apparmor.c
+++ b/src/security/security_apparmor.c
@@ -1109,8 +1109,8 @@ AppArmorSetFDLabel(virSecurityManager *mgr,
                    virDomainDef *def,
                    int fd)
 {
-    char *proc = NULL;
-    char *fd_path = NULL;
+    g_autofree char *proc = NULL;
+    g_autofree char *fd_path = NULL;
 
     virSecurityLabelDef *secdef =
         virDomainDefGetSecurityLabelDef(def, SECURITY_APPARMOR_NAME);