From: Volker Lendecke <vl@samba.org>
Date: Fri, 30 Mar 2018 17:19:24 +0000 (-0500)
Subject: groupdb: Fix CID 1167984 Ignoring number of bytes read
X-Git-Tag: talloc-2.1.13~58
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76babda4ef13111e402fcfac10d6f9c3d7bb75e9;p=thirdparty%2Fsamba.git

groupdb: Fix CID 1167984 Ignoring number of bytes read

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c
index ac70fe68c48..1a8670e66b0 100644
--- a/source3/groupdb/mapping.c
+++ b/source3/groupdb/mapping.c
@@ -237,9 +237,13 @@ int smb_create_group(const char *unix_group, gid_t *new_gid)
 
 		if (fd != 0) {
 			fstring output;
+			ssize_t nread;
 
 			*new_gid = 0;
-			if (read(fd, output, sizeof(output)) > 0) {
+
+			nread = read(fd, output, sizeof(output)-1);
+			if (nread > 0) {
+				output[nread] = '\0';
 				*new_gid = (gid_t)strtoul(output, NULL, 10);
 			}