From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 9 Mar 2015 17:19:23 +0000 (+0100)
Subject: fsck: simplification
X-Git-Tag: v220~866
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76bb3afd811ea33fcd20b278fe04ff0a7be203fd;p=thirdparty%2Fsystemd.git

fsck: simplification
---

diff --git a/src/fsckd/fsckd.c b/src/fsckd/fsckd.c
index d4e9896e91c..0f647468dd0 100644
--- a/src/fsckd/fsckd.c
+++ b/src/fsckd/fsckd.c
@@ -252,20 +252,22 @@ static int connect_plymouth(Manager *m) {
         int r;
 
         /* try to connect or reconnect if sending a message */
-        if (m->plymouth_fd <= 0) {
-                m->plymouth_fd = socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC, 0);
-                if (m->plymouth_fd < 0) {
-                        return log_warning_errno(errno, "Connection to plymouth socket failed: %m");
-                }
-                if (connect(m->plymouth_fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + 1 + strlen(sa.un.sun_path+1)) < 0) {
-                        on_plymouth_disconnect(m);
-                        return log_warning_errno(errno, "Couldn't connect to plymouth: %m");
-                }
-                r = sd_event_add_io(m->event, NULL, m->plymouth_fd, EPOLLIN, plymouth_feedback_handler, m);
-                if (r < 0) {
-                        on_plymouth_disconnect(m);
-                        return log_warning_errno(r, "Can't listen to plymouth socket: %m");
-                }
+        if (m->plymouth_fd >= 0)
+                return 0;
+
+        m->plymouth_fd = socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC, 0);
+        if (m->plymouth_fd < 0)
+                return log_warning_errno(errno, "Connection to plymouth socket failed: %m");
+
+        if (connect(m->plymouth_fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + 1 + strlen(sa.un.sun_path+1)) < 0) {
+                on_plymouth_disconnect(m);
+                return log_warning_errno(errno, "Couldn't connect to plymouth: %m");
+        }
+
+        r = sd_event_add_io(m->event, NULL, m->plymouth_fd, EPOLLIN, plymouth_feedback_handler, m);
+        if (r < 0) {
+                on_plymouth_disconnect(m);
+                return log_warning_errno(r, "Can't listen to plymouth socket: %m");
         }
 
         return 0;