From: Günther Deschner <gd@samba.org>
Date: Tue, 13 Jan 2009 12:14:36 +0000 (+0100)
Subject: eventlog: more eventlog record idl fixes.
X-Git-Tag: samba-4.0.0alpha6~113
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76f137b908c233db36e7b64d77d7ceb3ce82dfd0;p=thirdparty%2Fsamba.git

eventlog: more eventlog record idl fixes.

- treat eventlogEventTypes as an enum.
- do not align the full eventlog entry.
- set range on number of strings according to docs.
- make a little more obvious what the reserved field stands for.

Guenther
---

diff --git a/librpc/idl/eventlog.idl b/librpc/idl/eventlog.idl
index 584d6717a04..51b3ea706e3 100644
--- a/librpc/idl/eventlog.idl
+++ b/librpc/idl/eventlog.idl
@@ -18,7 +18,7 @@ import "lsa.idl", "security.idl";
 		EVENTLOG_BACKWARDS_READ  = 0x0008
 	} eventlogReadFlags;
 
-	typedef bitmap {
+	typedef [public] enum {
 		EVENTLOG_SUCCESS          = 0x0000,
 		EVENTLOG_ERROR_TYPE       = 0x0001,
 		EVENTLOG_WARNING_TYPE     = 0x0002,
@@ -32,15 +32,15 @@ import "lsa.idl", "security.idl";
 		uint16 unknown1;
 	} eventlog_OpenUnknown0;
 	
-	typedef [public] struct { 
+	typedef [flag(NDR_NOALIGN),public] struct {
 		uint32 size;
-		[value(0x654c664C)] uint32 reserved; /* "eLfL" */
+		[charset(DOS),value("eLfL")] uint8 reserved[4];
 		uint32 record_number;
 		time_t time_generated;
 		time_t time_written;
 		uint32 event_id;
-		uint16 event_type;
-		uint16 num_of_strings;
+		eventlogEventTypes event_type;
+		[range(0,256)] uint16 num_of_strings;
 		uint16 event_category;
 		uint16 reserved_flags;
 		uint32 closing_record_number;