From: Volker Lendecke <vl@samba.org>
Date: Tue, 21 Nov 2017 19:41:47 +0000 (+0100)
Subject: libgpo: Fix CID 1422263 Resource leak
X-Git-Tag: talloc-2.1.11~420
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76f370edae59d11143edb5983e3277b33d9af422;p=thirdparty%2Fsamba.git

libgpo: Fix CID 1422263 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 22 02:03:17 CET 2017 on sn-devel-144
---

diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
index 619985239cb..d7bb17382b2 100644
--- a/libgpo/pygpo.c
+++ b/libgpo/pygpo.c
@@ -248,6 +248,7 @@ static PyObject* py_ads_connect(ADS *self)
 		if (!strupper_m(self->ads_ptr->auth.realm)) {
 			PyErr_SetString(PyExc_SystemError, "Failed to strdup");
 			TALLOC_FREE(frame);
+			SAFE_FREE(passwd);
 			Py_RETURN_FALSE;
 		}
 
@@ -255,6 +256,7 @@ static PyObject* py_ads_connect(ADS *self)
 		if (!ADS_ERR_OK(status)) {
 			PyErr_SetString(PyExc_SystemError, "ads_connect() failed");
 			TALLOC_FREE(frame);
+			SAFE_FREE(passwd);
 			Py_RETURN_FALSE;
 		}
 	}