From: Steven Murdoch Date: Wed, 31 Aug 2011 22:40:29 +0000 (+0100) Subject: Fix off-by-one error when allocating memory in test_util_split_lines() X-Git-Tag: tor-0.2.3.3-alpha~10 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=76fde28475a5b977d1fa94d06c116ec39a386ac8;p=thirdparty%2Ftor.git Fix off-by-one error when allocating memory in test_util_split_lines() Triggered "failed OVER picket-fence magic-number check (err 27)" when memory debugging using dmalloc is enabled (at 'low' or higher). --- diff --git a/src/test/test_util.c b/src/test/test_util.c index 3b5d85f376..b903cbfb9c 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -1637,7 +1637,8 @@ test_util_split_lines(void *ptr) for (i=0; tests[i].orig_line; i++) { sl = smartlist_create(); - orig_line = tor_malloc(tests[i].orig_length); + /* Allocate space for string and trailing NULL */ + orig_line = tor_malloc(tests[i].orig_length + 1); memcpy(orig_line, tests[i].orig_line, tests[i].orig_length + 1); tor_split_lines(sl, orig_line, tests[i].orig_length);