From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 30 Oct 2023 22:20:05 +0000 (+1300)
Subject: s3:utils: Check return value of samba_cmdline_init() (CID 1548345)
X-Git-Tag: talloc-2.4.2~880
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=77183ded7de9d5b23663aa5f68a94a9c9b87902c;p=thirdparty%2Fsamba.git

s3:utils: Check return value of samba_cmdline_init() (CID 1548345)

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/utils/wspsearch.c b/source3/utils/wspsearch.c
index 6b918b9db94..d2235fa8193 100644
--- a/source3/utils/wspsearch.c
+++ b/source3/utils/wspsearch.c
@@ -591,10 +591,16 @@ int main(int argc, char **argv)
 	struct dcerpc_binding_handle *h = NULL;
 	struct cli_state *c = NULL;
 	uint32_t flags = CLI_FULL_CONNECTION_IPC;
+	bool ok;
 
-	samba_cmdline_init(frame,
-			   SAMBA_CMDLINE_CONFIG_CLIENT,
-			   false /* require_smbconf */);
+	ok = samba_cmdline_init(frame,
+				SAMBA_CMDLINE_CONFIG_CLIENT,
+				false /* require_smbconf */);
+	if (!ok) {
+		DBG_ERR("Failed to set up cmdline parser\n");
+		result = -1;
+		goto out;
+	}
 
 	pc = samba_popt_get_context("wspsearch",
 			argc,