From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 15 Jan 2020 15:30:03 +0000 (-0500)
Subject: Tell static analyzer that having ntservice functions not exist is ok
X-Git-Tag: tor-0.4.3.1-alpha~20^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=77246dc0d8b90e99bb411475da1911919799dae8;p=thirdparty%2Ftor.git

Tell static analyzer that having ntservice functions not exist is ok

When we made these functions exist unconditionally (as macros on
non-windows platforms), we started to get a dead-code warning on
Coverity.  We now use a macro to tell coverity not to worry about
this particular dead-code instance.
---

diff --git a/src/app/main/main.c b/src/app/main/main.c
index 36f85c6a40..b533406eaa 100644
--- a/src/app/main/main.c
+++ b/src/app/main/main.c
@@ -1240,7 +1240,7 @@ tor_run_main(const tor_main_configuration_t *tor_cfg)
 
   int done = 0;
   result = nt_service_parse_options(argc, argv, &done);
-  if (done)
+  if (POSSIBLE(done))
     goto done;
 
   pubsub_install();