From: Emil Velikov Date: Sat, 18 Jul 2026 15:23:18 +0000 (+0100) Subject: testsuite: add FIXME note about libkmod-internal.h include X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=773f98cae675b7125a09421acfa82a2fc498ef6b;p=thirdparty%2Fkmod.git testsuite: add FIXME note about libkmod-internal.h include We really do not want to have dependency on an internal header(s), since it opens the possibility of leaking implementation details into what should be API level tests. Although, it could be that we should remove kmod_list from the public API all together... Something for another day either way. Signed-off-by: Emil Velikov Link: https://github.com/kmod-project/kmod/pull/450 Signed-off-by: Lucas De Marchi --- diff --git a/testsuite/test-blacklist.c b/testsuite/test-blacklist.c index b7f3967..a9e0a92 100644 --- a/testsuite/test-blacklist.c +++ b/testsuite/test-blacklist.c @@ -16,6 +16,7 @@ /* good luck building a kmod_list outside of the library... makes this blacklist * function rather pointless */ +/* FIXME: convert the test so we don't need the internal header */ #include #include "testsuite.h"