From: Shane Lontis <shane.lontis@oracle.com>
Date: Mon, 24 Aug 2020 02:16:24 +0000 (+1000)
Subject: Fix coverity CID #1457935 - Check return value in ffc_params.c for BIO_indent/BIO_put... 
X-Git-Tag: openssl-3.0.0-alpha7~385
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=776cf98b493768de02f798f71f6b30c40deb3506;p=thirdparty%2Fopenssl.git

Fix coverity CID #1457935 - Check return value in ffc_params.c for BIO_indent/BIO_puts calls.

Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
(Merged from https://github.com/openssl/openssl/pull/12708)
---

diff --git a/crypto/ffc/ffc_params.c b/crypto/ffc/ffc_params.c
index ac767c0a1cb..c980ea00180 100644
--- a/crypto/ffc/ffc_params.c
+++ b/crypto/ffc/ffc_params.c
@@ -313,8 +313,10 @@ int ffc_params_print(BIO *bp, const FFC_PARAMS *ffc, int indent)
         goto err;
     if (ffc->seed != NULL) {
         size_t i;
-        BIO_indent(bp, indent, 128);
-        BIO_puts(bp, "seed:");
+
+        if (!BIO_indent(bp, indent, 128)
+            || BIO_puts(bp, "seed:") <= 0)
+            goto err;
         for (i = 0; i < ffc->seedlen; i++) {
             if ((i % 15) == 0) {
                 if (BIO_puts(bp, "\n") <= 0
@@ -329,8 +331,8 @@ int ffc_params_print(BIO *bp, const FFC_PARAMS *ffc, int indent)
             return 0;
     }
     if (ffc->pcounter != -1) {
-        BIO_indent(bp, indent, 128);
-        if (BIO_printf(bp, "counter: %d\n", ffc->pcounter) <= 0)
+        if (!BIO_indent(bp, indent, 128)
+            || BIO_printf(bp, "counter: %d\n", ffc->pcounter) <= 0)
             goto err;
     }
     return 1;