From: Romain Pokrzywka <romain@kdab.com>
Date: Sun, 8 Aug 2010 21:54:35 +0000 (+0200)
Subject: fix socket descriptor leak in _dbus_connect_tcp_socket_with_nonce
X-Git-Tag: dbus-1.4.0~16
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=77ee59e06dbb6facda9d4ebdcf47f14adfea091e;p=thirdparty%2Fdbus.git

fix socket descriptor leak in _dbus_connect_tcp_socket_with_nonce
---

diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
index aad342ca6..7f9d5596a 100644
--- a/dbus/dbus-sysdeps-win.c
+++ b/dbus/dbus-sysdeps-win.c
@@ -1294,6 +1294,7 @@ _dbus_connect_tcp_socket_with_nonce (const char     *host,
       dbus_set_error (error,
                       _dbus_error_from_errno (errno),
                       "Unknown address family %s", family);
+      closesocket (fd);
       return -1;
     }
   hints.ai_protocol = IPPROTO_TCP;
@@ -1314,6 +1315,9 @@ _dbus_connect_tcp_socket_with_nonce (const char     *host,
       return -1;
     }
 
+  closesocket (fd);
+  fd = -1;
+
   tmp = ai;
   while (tmp)
     {