From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 28 May 2015 16:27:22 +0000 (-0400)
Subject: Add assertions to crypto_dh_dup()
X-Git-Tag: tor-0.2.7.2-alpha~134
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7816ba8f1a3381d28d78aa7812f1c26edd7cdd0e;p=thirdparty%2Ftor.git

Add assertions to crypto_dh_dup()

Without these, coverity is annoyed that aren't checking for NULL in bench.c

CID 1293335 -- found by coverity.
---

diff --git a/src/common/crypto.c b/src/common/crypto.c
index d77d5e20dc..afaf93aed2 100644
--- a/src/common/crypto.c
+++ b/src/common/crypto.c
@@ -1979,6 +1979,8 @@ crypto_dh_t *
 crypto_dh_dup(const crypto_dh_t *dh)
 {
   crypto_dh_t *dh_new = tor_malloc_zero(sizeof(crypto_dh_t));
+  tor_assert(dh);
+  tor_assert(dh->dh);
   dh_new->dh = dh->dh;
   DH_up_ref(dh->dh);
   return dh_new;