From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 26 Jun 2023 05:09:22 +0000 (+1200)
Subject: s4:kdc: Don’t overwrite error code
X-Git-Tag: talloc-2.4.1~174
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7828c6535cd61ef9ff64417226fcd8ae9dad23e9;p=thirdparty%2Fsamba.git

s4:kdc: Don’t overwrite error code

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Jun 26 12:11:30 UTC 2023 on atb-devel-224
---

diff --git a/source4/kdc/wdc-samba4.c b/source4/kdc/wdc-samba4.c
index be1500a4804..6b3731d55de 100644
--- a/source4/kdc/wdc-samba4.c
+++ b/source4/kdc/wdc-samba4.c
@@ -503,7 +503,7 @@ static krb5_error_code samba_wdc_reget_pac(void *priv, astgs_request_t r,
 		krb5_error_code ret2;
 
 		ret2 = hdb_samba4_set_steal_server_audit_info(r, server_audit_info);
-		if (ret2) {
+		if (ret == 0) {
 			ret = ret2;
 		}
 	}
@@ -511,7 +511,7 @@ static krb5_error_code samba_wdc_reget_pac(void *priv, astgs_request_t r,
 		krb5_error_code ret2;
 
 		ret2 = hdb_samba4_set_ntstatus(r, status, ret);
-		if (ret2) {
+		if (ret == 0) {
 			ret = ret2;
 		}
 	}