From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Mon, 27 Mar 2023 07:36:56 +0000 (+0200)
Subject: API Auth: increase SOA serial only once in PUT
X-Git-Tag: rec-5.0.0-alpha1~24^2~15
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=78335d4ffa0dad7ba2f9f0c563326035a44cbbfd;p=thirdparty%2Fpdns.git

API Auth: increase SOA serial only once in PUT

Already done by updateDomainSettingsFromDocument.
---

diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index bd35a8aad6..d736c09ffd 100644
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -1951,7 +1951,6 @@ static void apiServerZoneDetail(HttpRequest* req, HttpResponse* resp) {
 
         if (rr.qtype.getCode() == QType::SOA && rr.qname==zonename) {
           haveSoa = true;
-          increaseSOARecord(rr, soaEditApiKind, soaEditKind);
         }
       }
 
@@ -1978,6 +1977,7 @@ static void apiServerZoneDetail(HttpRequest* req, HttpResponse* resp) {
       di.backend->startTransaction(zonename, -1);
     }
 
+    // updateDomainSettingsFromDocument will rectify the zone and update SOA serial.
     updateDomainSettingsFromDocument(B, di, zonename, document, zoneWasModified);
     di.backend->commitTransaction();