From: Timo Sirainen <tss@iki.fi>
Date: Fri, 19 Feb 2010 02:28:07 +0000 (+0200)
Subject: auth: Don't leak memory if auth client sends a buggy request.
X-Git-Tag: 2.0.beta3~40
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7904d81873b36f8464c96be415881f92518452e6;p=thirdparty%2Fdovecot%2Fcore.git

auth: Don't leak memory if auth client sends a buggy request.

--HG--
branch : HEAD
---

diff --git a/src/auth/auth-request-handler.c b/src/auth/auth-request-handler.c
index 7fc54235b7..b828dea419 100644
--- a/src/auth/auth-request-handler.c
+++ b/src/auth/auth-request-handler.c
@@ -366,6 +366,7 @@ bool auth_request_handler_auth_begin(struct auth_request_handler *handler,
 		i_error("BUG: Authentication client %u "
 			"sent AUTH parameters after 'resp'",
 			handler->client_pid);
+		auth_request_unref(&request);
 		return FALSE;
 	}
 
@@ -373,6 +374,7 @@ bool auth_request_handler_auth_begin(struct auth_request_handler *handler,
 		i_error("BUG: Authentication client %u "
 			"didn't specify service in request",
 			handler->client_pid);
+		auth_request_unref(&request);
 		return FALSE;
 	}