From: Andreas Schneider <asn@samba.org>
Date: Wed, 8 May 2019 14:31:10 +0000 (+0200)
Subject: s3:rpc_server: Do not free the tdbname before we printed it
X-Git-Tag: tdb-1.4.1~161
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=790d7e34cbe4e190d6acdd24696efe53944cd4a6;p=thirdparty%2Fsamba.git

s3:rpc_server: Do not free the tdbname before we printed it

Found by GCC 9.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/rpc_server/eventlog/srv_eventlog_nt.c b/source3/rpc_server/eventlog/srv_eventlog_nt.c
index ce27dd530e1..5093125a6f6 100644
--- a/source3/rpc_server/eventlog/srv_eventlog_nt.c
+++ b/source3/rpc_server/eventlog/srv_eventlog_nt.c
@@ -95,13 +95,13 @@ static bool elog_check_access( EVENTLOG_INFO *info, const struct security_token
 			tdbname,
 			SECINFO_OWNER | SECINFO_GROUP | SECINFO_DACL,
 			&sec_desc);
-	TALLOC_FREE( tdbname );
-
 	if (!NT_STATUS_IS_OK(status)) {
 		DEBUG(5,("elog_check_access: Unable to get NT ACL for %s: %s\n",
 			tdbname, nt_errstr(status)));
+		TALLOC_FREE(tdbname);
 		return False;
 	}
+	TALLOC_FREE(tdbname);
 
 	ace = talloc_zero(sec_desc, struct security_ace);
 	if (ace == NULL) {