From: Aram Sargsyan <aram@isc.org>
Date: Fri, 15 Dec 2023 09:43:36 +0000 (+0000)
Subject: Use atomic store operations instead of atomic initialize
X-Git-Tag: v9.19.21~41^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=791a046cc7eca91350984f0844ebfc5ea161a521;p=thirdparty%2Fbind9.git

Use atomic store operations instead of atomic initialize

The atomic_init() function makes sense to use with structure's
members when creating a new instance of a strucutre. In other
places, use atomic store operations instead, in order to avoid
data races.
---

diff --git a/lib/dns/xfrin.c b/lib/dns/xfrin.c
index 148449ce626..697e8507c90 100644
--- a/lib/dns/xfrin.c
+++ b/lib/dns/xfrin.c
@@ -1260,8 +1260,8 @@ xfrin_start(dns_xfrin_t *xfr) {
 		 * The "SOA before" mode is used, where the SOA request is
 		 * using the same transport as the XFR.
 		 */
-		atomic_init(&xfr->soa_transport_type,
-			    dns_xfrin_gettransporttype(xfr));
+		atomic_store_relaxed(&xfr->soa_transport_type,
+				     dns_xfrin_gettransporttype(xfr));
 	}
 
 	/* Set the maximum timer */
@@ -1552,10 +1552,10 @@ xfrin_send_request(dns_xfrin_t *xfr) {
 		CHECK(add_opt(msg, udpsize, reqnsid, reqexpire));
 	}
 
-	atomic_init(&xfr->nmsg, 0);
-	atomic_init(&xfr->nrecs, 0);
-	atomic_init(&xfr->nbytes, 0);
-	atomic_init(&xfr->start, isc_time_now());
+	atomic_store_relaxed(&xfr->nmsg, 0);
+	atomic_store_relaxed(&xfr->nrecs, 0);
+	atomic_store_relaxed(&xfr->nbytes, 0);
+	atomic_store_relaxed(&xfr->start, isc_time_now());
 
 	msg->id = xfr->id;
 	if (xfr->tsigctx != NULL) {