From: Nick Mathewson <nickm@torproject.org>
Date: Wed, 5 Sep 2018 12:34:14 +0000 (-0400)
Subject: Fix a reverse-inull warning from coverity in new code.
X-Git-Tag: tor-0.3.5.1-alpha~88
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=79a7fbb79b7f5a5a8bb3552f3c071498a34e5b84;p=thirdparty%2Ftor.git

Fix a reverse-inull warning from coverity in new code.
---

diff --git a/src/lib/tls/tortls_openssl.c b/src/lib/tls/tortls_openssl.c
index cfe859adf3..5b1cdeec04 100644
--- a/src/lib/tls/tortls_openssl.c
+++ b/src/lib/tls/tortls_openssl.c
@@ -659,8 +659,7 @@ tor_tls_context_new(crypto_pk_t *identity, unsigned int key_lifetime,
   tls_log_errors(NULL, LOG_WARN, LD_NET, "creating TLS context");
   if (pkey)
     EVP_PKEY_free(pkey);
-  if (result)
-    tor_tls_context_decref(result);
+  tor_tls_context_decref(result);
   return NULL;
 }