From: Volker Lendecke <vl@samba.org>
Date: Sat, 27 Jun 2009 10:20:18 +0000 (+0200)
Subject: Stop listening for inotify data when there's none
X-Git-Tag: talloc-2.0.0~906
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=79c299f96fe1780c0ca09d2ed429a2640ec56744;p=thirdparty%2Fsamba.git

Stop listening for inotify data when there's none

There have been some reports that we're flooding syslog with "No data on
inotify fd?!". I haven't been able to reproduce this yet. Until then, it is
better to just list this message once.
---

diff --git a/source3/smbd/notify_inotify.c b/source3/smbd/notify_inotify.c
index a80927b830f..26570a22162 100644
--- a/source3/smbd/notify_inotify.c
+++ b/source3/smbd/notify_inotify.c
@@ -241,6 +241,7 @@ static void inotify_handler(struct event_context *ev, struct fd_event *fde,
 	if (ioctl(in->fd, FIONREAD, &bufsize) != 0 || 
 	    bufsize == 0) {
 		DEBUG(0,("No data on inotify fd?!\n"));
+		TALLOC_FREE(fde);
 		return;
 	}